From 343ea7605b3c47235ef43aebc0952b59a4342eaf Mon Sep 17 00:00:00 2001 From: Serkyo Date: Mon, 13 Jul 2026 00:39:49 +0200 Subject: [PATCH] chore(server): add reasons to expect attributes --- crates/server/src/save/region_actor.rs | 6 ++++-- crates/server/src/world_server.rs | 12 ++++++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/crates/server/src/save/region_actor.rs b/crates/server/src/save/region_actor.rs index 77e7b02..07430d7 100644 --- a/crates/server/src/save/region_actor.rs +++ b/crates/server/src/save/region_actor.rs @@ -47,8 +47,10 @@ pub struct SaveActor { /// The sending end of the request channel; cloned into every worker so it can issue reads. request_tx: Sender, /// The actor thread handle, retained so it can be joined on shutdown. - // * Retained ahead of a dedicated shutdown path; not yet read because the server has no graceful-stop sequence. - #[expect(dead_code)] + #[expect( + dead_code, + reason = "retained for a future graceful-shutdown join path" + )] handle: JoinHandle<()>, } diff --git a/crates/server/src/world_server.rs b/crates/server/src/world_server.rs index 561ae5a..09a7aec 100644 --- a/crates/server/src/world_server.rs +++ b/crates/server/src/world_server.rs @@ -46,13 +46,17 @@ pub struct ServerWorld { /// Positions dispatched to a worker but not yet returned, preventing the same chunk being re-dispatched on subsequent passes. in_flight: HashSet, /// The dedicated thread owning all region files, kept alive for the world's lifetime. - // Retained so its request channel stays open for the workers; not read again after construction. - #[expect(dead_code)] + #[expect( + dead_code, + reason = "retained to keep the save request channel open for the workers" + )] save_actor: SaveActor, /// Handles to the generation worker threads, retained so they can be joined on shutdown. - // * NOTE: Retained ahead of a dedicated shutdown path // TODO: Remove once the server has a graceful-stop sequence - #[expect(dead_code)] + #[expect( + dead_code, + reason = "retained for a future graceful-shutdown join path" + )] workers: Vec>, /// The same read-only generator handle the workers share, held so eviction can regenerate a chunk's baseline to diff against. generator: Arc,